Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stub generation #1195

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fix stub generation #1195

merged 2 commits into from
Dec 8, 2023

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Dec 6, 2023

Stub generation is broken :

  • The stub generator is launched in the wrong directory
  • The stub generator don't depend of the binding and then can be launched before

@jorisv
Copy link
Contributor Author

jorisv commented Dec 6, 2023

Before merge, I must check if pyc generation dependency is well defined

@jorisv jorisv self-assigned this Dec 6, 2023
@jorisv jorisv requested a review from nim65s December 6, 2023 15:38
@jorisv jorisv marked this pull request as ready for review December 6, 2023 15:38
@jorisv
Copy link
Contributor Author

jorisv commented Dec 6, 2023

Before merge, I must check if pyc generation dependency is well defined

done

cmastalli
cmastalli approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @jorisv!

I will proceed with merging this after sorting out the issue with our CI. Please bear with me.

@cmastalli cmastalli merged commit 891c264 into loco-3d:devel Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarpent jcarpent jcarpent approved these changes

@cmastalli cmastalli cmastalli approved these changes

@nim65s nim65s Awaiting requested review from nim65s

Assignees

@jorisv jorisv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorisv @jcarpent @cmastalli