feat: Upgrade actix and actix-web
#360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from 0.7 and 0.7 to 0.13 and 4.8 respectively. Furthermore add `actix-files` and `actix-web-actors` as new dependencies for functionalities which were extracted from `actix-web` in the past.
|
As @vlnzrv pointed out in #291, this example will (without the upgrade) stop working with rust 1.80.0 which is going to be released not in a couple of weeks, but eight days, if I'm not missing something else here. @locka99 I'll look into it later this afternoon, but it might be worthwhile to take half an hour in possibly the next week to review this, after I found a fix for the ungraceful runtime termination and had tested this. |
|
I just tested this and it should not be merged yet. |
|
While this update is conceptually a good idea, I found a less invasive way to ensure operability past Thursday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this eventually resolves #291.