Fix codclimate/sourcelevel issues

locaweb · Mar 10, 2022 · e61356b · e61356b
1 parent fec3f81
commit e61356b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/cassette/authentication.rb b/lib/cassette/authentication.rb
@@ -36,14 +36,16 @@ def ticket_user(ticket, service = config.service)
 
           logger.info("Validation resut: #{response.inspect}")
 
+          return nil unless ticket_response.login
+
           Cassette::Authentication::User.new(
             login: ticket_response.login,
             name: ticket_response.name,
             authorities: ticket_response.authorities,
             extra_attributes: ticket_response.extra_attributes,
             ticket: ticket,
             config: config
-          ) if ticket_response.login
+          )
         rescue => exception
           logger.error "Error while authenticating ticket #{ticket}: #{exception.message}"
           raise Cassette::Errors::Forbidden, exception.message

diff --git a/lib/cassette/authentication/user.rb b/lib/cassette/authentication/user.rb
@@ -11,6 +11,7 @@ class User
 
       attr_accessor :login, :name, :authorities, :email, :ticket, :type,
                     :extra_attributes
+
       def_delegators :@authorities, :has_role?, :has_raw_role?
 
       def initialize(attrs = {})
@@ -23,7 +24,7 @@ def initialize(attrs = {})
         @extra_attributes = attrs[:extra_attributes]
         @authorities      = Cassette::Authentication::Authorities
                             .parse(attrs.fetch(:authorities, '[]'),
-                                   config && config.base_authority)
+                                   config&.base_authority)
       end
 
       %w(customer employee).each do |type|