Fix TopologyPreservingSimplifier to prevent jumping components causing incorrect topology #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-jts
changed the title
dr-jts
changed the title
pramsey
added a commit
to libgeos/geos
that referenced
this pull request
Dec 8, 2023
…g incorrect topology (#1012) Fixes a long-standing bug in TopologyPreservingSimplifier which created incorrect output due to simplified edges "jumping" over components in the input geometry. The fix handles both polygonal and linear inputs. (Previously, polygonal inputs with "jumps" produced invalid results. Linear inputs produced results whose topology did not match the input). See locationtech/jts#1024
pramsey
added a commit
to libgeos/geos
that referenced
this pull request
Dec 8, 2023
…g incorrect topology (#1012) Fixes a long-standing bug in TopologyPreservingSimplifier which created incorrect output due to simplified edges "jumping" over components in the input geometry. The fix handles both polygonal and linear inputs. (Previously, polygonal inputs with "jumps" produced invalid results. Linear inputs produced results whose topology did not match the input). See locationtech/jts#1024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a long-standing bug in
TopologyPreservingSimplifierwhich created incorrect output due to simplified edges "jumping" over components in the input geometry.The fix handles both polygonal and linear inputs. (Previously, polygonal inputs with "jumps" produced invalid results. Linear inputs produced results whose topology did not match the input).
Before fix
After fix
Fixes #428.
Porting this to GEOS will fix the following issues:
vector::ops::transformations::tests::test_simplify_preserve_topologymacOS test regression georust/gdal#443