API to modify user password #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcads
reviewed
Nov 5, 2021
| if (merchant && (await merchant.isCorrectPassword(currentPass))) { | ||
| const salt = await bcrypt.genSalt(10); | ||
| const password = await bcrypt.hash(newPass, salt); | ||
| merchant = await Merchant.findByIdAndUpdate(req.user._id, { password }); |
There was a problem hiding this comment.
This is too expensive, I think we should be able to do it like this.
Suggested change
| merchant = await Merchant.findByIdAndUpdate(req.user._id, { password }); | |
| merchant.password = password; |
We want to minimize DB calls as much as possible.
Comment on lines
118
to
124
| async function changePassword(req, res) { | ||
| const { currentPass, newPass } = req.body; | ||
| let merchant = await Merchant.findById(req.user._id); | ||
| if (merchant && (await merchant.isCorrectPassword(currentPass))) { | ||
| const salt = await bcrypt.genSalt(10); | ||
| const password = await bcrypt.hash(newPass, salt); | ||
| merchant = await Merchant.findByIdAndUpdate(req.user._id, { password }); |
There was a problem hiding this comment.
Or more precise
Suggested change
| async function changePassword(req, res) { | |
| const { currentPass, newPass } = req.body; | |
| let merchant = await Merchant.findById(req.user._id); | |
| if (merchant && (await merchant.isCorrectPassword(currentPass))) { | |
| const salt = await bcrypt.genSalt(10); | |
| const password = await bcrypt.hash(newPass, salt); | |
| merchant = await Merchant.findByIdAndUpdate(req.user._id, { password }); | |
| async function changePassword(req, res) { | |
| const { currentPass, newPass } = req.body; | |
| const salt = await bcrypt.genSalt(10); | |
| const password = await bcrypt.hash(newPass, salt); | |
| merchant = await Merchant.findByIdAndUpdate(req.user._id, { password }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement an API for the front-end to use in order to modify the user's password.
Fixes #47