Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document snowpipe #37

Merged
merged 7 commits into from
Jul 9, 2024
Merged

document snowpipe #37

merged 7 commits into from
Jul 9, 2024

Conversation

HarshCasper
Copy link
Member

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-37.surge.sh 🎊

@HarshCasper HarshCasper requested review from whummer and yingw787 July 8, 2024 07:19
yingw787
yingw787 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@yingw787 yingw787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run through the instructions myself, but it looks good from reading it 🚀

@yingw787
Copy link
Contributor

yingw787 commented Jul 8, 2024

WAIT

Actually, given what happened with the Audacy demo (CREATE STAGE using a hardcoded bucket name), do we want to document how we create a bucket and then create a STAGE based off of it? @whummer

whummer
whummer approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, kudos for adding this sample for Snowpipes @HarshCasper ! 😎

Actually, given what happened with the Audacy demo (CREATE STAGE using a hardcoded bucket name), do we want to document how we create a bucket and then create a STAGE based off of it? @whummer

@yingw787 I believe that should be fixed in the meantime - at least I was able to run the sample (with my comments applied). Let's look into that offline and see if we can still reproduce the issue 👍 (but shouldn't block the merge)

Added a couple of comments/suggestions - let's please address them prior to merging @HarshCasper

content/en/user-guide/snowpipe/index.md Outdated Show resolved Hide resolved
content/en/user-guide/snowpipe/index.md Outdated Show resolved Hide resolved
content/en/user-guide/snowpipe/index.md Outdated Show resolved Hide resolved
content/en/user-guide/snowpipe/index.md Outdated Show resolved Hide resolved
content/en/user-guide/snowpipe/index.md Show resolved Hide resolved
content/en/user-guide/snowpipe/index.md Show resolved Hide resolved
HarshCasper and others added 6 commits July 9, 2024 12:16
@HarshCasper @whummer
Update content/en/user-guide/snowpipe/index.md
08cfdde 
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
@HarshCasper @whummer
Update content/en/user-guide/snowpipe/index.md
c468323 
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
@HarshCasper @whummer
Update content/en/user-guide/snowpipe/index.md
60caff1 
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
@HarshCasper @whummer
Update content/en/user-guide/snowpipe/index.md
1cb44d6 
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
@HarshCasper @whummer
Update content/en/user-guide/snowpipe/index.md
7da4e93 
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
@HarshCasper
add create table section
b734fde
@HarshCasper HarshCasper merged commit a06d388 into main Jul 9, 2024
2 checks passed
@HarshCasper HarshCasper deleted the snowpipe branch July 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingw787 yingw787 yingw787 approved these changes

@whummer whummer whummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarshCasper @yingw787 @whummer