Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate function coverage doc generation #23

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

HarshCasper
Copy link
Member

@HarshCasper HarshCasper requested a review from whummer April 15, 2024 09:07
Copy link

github-actions bot commented Apr 15, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-23.surge.sh 🎊

@HarshCasper HarshCasper requested review from yingw787 and ackdav April 15, 2024 09:07
@HarshCasper HarshCasper force-pushed the function-doc-automate branch from 1de980c to c6533f7 Compare April 15, 2024 09:08
rm -f content/en/references/coverage/index.md && mv index.md content/en/references/coverage/

- name: Commit changes
uses: EndBug/add-and-commit@v9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this action pushing the commit straight up to the repo's main branch? I've noticed that in other places we're creating a PR, e.g., for the parity coverage docs: https://github.com/localstack/docs/blob/708939a98c4e2f6732989c139e0dd88b27e2ee8d/.github/workflows/docs-parity-updates.yml#L107 (no strong preference from my side, maybe @yingw787 @ackdav you have some additional thoughts on what would be the best approach here)

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarshCasper Looks good to merge from my side - we can see what it feels like for a couple of weeks, and then adjust over time, as needed.. 👍

@whummer whummer merged commit d51fab4 into main Apr 19, 2024
2 checks passed
@whummer whummer deleted the function-doc-automate branch April 19, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants