ESM-v2: Remove reference to unbound variable #11495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfurman
added
the
semver: patch
LocalStack Community integration with Pro 2 files 2 suites 1h 14m 47s ⏱️ Results for commit d79b272. |
gregfurman
requested review from
joe4dev,
dominikschubert and
dfangl
as code owners
joe4dev
approved these changes
Sep 10, 2024
| @@ -85,8 +84,6 @@ def send_events(self, events: list[dict]) -> dict: | |||
| "requestId": invoke_result["ResponseMetadata"]["RequestId"], | |||
| "exceptionType": "BadRequest", | |||
| "resourceArn": self.target_arn, | |||
| "functionError": function_error, | |||
There was a problem hiding this comment.
I see that this was the issue. Reverting this change fixes it because the executedVersion and function_error is not needed for batch item failures.
There was a problem hiding this comment.
Yes exactly. Not sure how I missed this when running the tests initially 🤔
There was a problem hiding this comment.
What can we do to catch such regressions in the future? Would better test coverage for batch failure handling catch this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
function_errorin batch error payloadexecutedVersionfrom batch error payload