Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Baichuan should not introduce freequency_penality parameters #3871

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

sxjeru
Copy link
Contributor

@sxjeru sxjeru commented Sep 10, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

# [baichuan] frequency_penalty must be between 1 and 2.

先尝试去掉 freequency_penality 的默认值(lobechat 默认为 0),看能否修复。
根据文档,不应该在此接口使用该参数。

fix #3356

📝 补充信息 | Additional Information

Copy link

vercel bot commented Sep 10, 2024

@sxjeru is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 10, 2024
@lobehubbot
Copy link
Member

👍 @sxjeru

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@sxjeru sxjeru marked this pull request as draft September 10, 2024 01:50
@dosubot dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Sep 10, 2024
@arvinxx
Copy link
Contributor

arvinxx commented Sep 10, 2024

为何不回滚到之前的实现?

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Why not roll back to the previous implementation?

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (89c8dd4) to head (b6e3cc4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3871    +/-   ##
========================================
  Coverage   91.82%   91.82%            
========================================
  Files         455      455            
  Lines       30433    30435     +2     
  Branches     2112     1963   -149     
========================================
+ Hits        27946    27948     +2     
  Misses       2487     2487            
Flag Coverage Δ
app 91.82% <100.00%> (+<0.01%) ⬆️
server 97.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sxjeru
Copy link
Contributor Author

sxjeru commented Sep 10, 2024

文档里没提到这个参数,应该不在请求中使用才对。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


This parameter is not mentioned in the documentation and should not be used in the request.

@arvinxx
Copy link
Contributor

arvinxx commented Sep 10, 2024

你先自己测试下?

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Can you test it yourself first?

@sxjeru sxjeru marked this pull request as ready for review September 10, 2024 02:40
@sxjeru
Copy link
Contributor Author

sxjeru commented Sep 10, 2024

可用。

image

@arvinxx arvinxx merged commit 66a061e into lobehub:main Sep 10, 2024
5 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @sxjeru ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
### [Version&nbsp;1.15.31](v1.15.30...v1.15.31)
<sup>Released on **2024-09-10**</sup>

#### 🐛 Bug Fixes

- **misc**: Baichuan should not introduce `freequency_penality` parameters.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Baichuan should not introduce `freequency_penality` parameters, closes [#3871](#3871) ([66a061e](66a061e))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.15.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sxjeru sxjeru deleted the patch-1 branch September 10, 2024 03:50
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Sep 10, 2024
### [Version&nbsp;1.58.15](v1.58.14...v1.58.15)
<sup>Released on **2024-09-10**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor brand implement for better custom.

#### 🐛 Bug Fixes

- **misc**: Baichuan should not introduce `freequency_penality` parameters, fix `/etc/resolv.conf`edit permission in docker image, fix claude 3.5 image with s3 url, fix tools calling in some edge cases, Gemini cannot input images when server database is enabled, Update baichuan param.

#### 💄 Styles

- **misc**: Add siliconcloud new model.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor brand implement for better custom, closes [lobehub#3868](https://github.com/bentwnghk/lobe-chat/issues/3868) ([815b366](815b366))

#### What's fixed

* **misc**: Baichuan should not introduce `freequency_penality` parameters, closes [lobehub#3871](https://github.com/bentwnghk/lobe-chat/issues/3871) ([66a061e](66a061e))
* **misc**: Fix `/etc/resolv.conf`edit permission in docker image, closes [lobehub#3880](https://github.com/bentwnghk/lobe-chat/issues/3880) ([fdaa190](fdaa190))
* **misc**: Fix claude 3.5 image with s3 url, closes [lobehub#3870](https://github.com/bentwnghk/lobe-chat/issues/3870) ([89c8dd4](89c8dd4))
* **misc**: Fix tools calling in some edge cases, closes [lobehub#3872](https://github.com/bentwnghk/lobe-chat/issues/3872) ([2ed759d](2ed759d))
* **misc**: Gemini cannot input images when server database is enabled, closes [lobehub#3370](https://github.com/bentwnghk/lobe-chat/issues/3370) ([eb552d2](eb552d2))
* **misc**: Update baichuan param, closes [lobehub#3356](https://github.com/bentwnghk/lobe-chat/issues/3356) ([29bced1](29bced1))

#### Styles

* **misc**: Add siliconcloud new model, closes [lobehub#3865](https://github.com/bentwnghk/lobe-chat/issues/3865) ([c6b5a45](c6b5a45))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷 released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants