Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style(ui): improve UI layout and text #3762

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented Sep 4, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

  • 调整404页面文本布局
  • 调整加载页面文本布局
  • 调整上传图片上传文件上传文件夹图标大小
  • 调整移动端,删除图片删除文件的图标大小
  • 调整文本等待中的字间距
  • 调整知识库部分文本
  • 更新部分依赖

  • Adjust text layout of loading page.
  • Adjust text layout for 404 page.
  • Adjust size of icons for Upload Image, Upload File and Upload Folder.
  • Adjust the icon size of Delete File and Delete Picture
  • Adjust the word spacing of the text Loading
  • Adjust some texts in the knowledge base
  • Update some dependencies

📝 补充信息 | Additional Information

Before After
BF1 AF1

Before After
BF2 AF2

Before After
BF3 AF3

Before After
BF4-1 AF4-1
BF4-2 AF4-2

Copy link

vercel bot commented Sep 4, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 4, 2024
@lobehubbot
Copy link
Member

👍 @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@dosubot dosubot bot added the 💄 Design Design an style | 样式问题 label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (82e2570) to head (25a37ab).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3762    +/-   ##
========================================
  Coverage   91.85%   91.85%            
========================================
  Files         459      459            
  Lines       30746    30746            
  Branches     2121     2963   +842     
========================================
  Hits        28241    28241            
  Misses       2505     2505            
Flag Coverage Δ
app 91.85% <ø> (ø)
server 97.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有有样式变更的地方都贴下图?

@@ -9,7 +9,7 @@
"title": "Launch {{name}}"
}
},
"appInitializing": "The application is initializing, please wait for a moment...",
"appInitializing": "Application is starting up",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Application is initializing...

locales/zh-CN/common.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/app/(main)/market/@detail/features/Header.tsx Outdated Show resolved Hide resolved
@arvinxx
Copy link
Contributor

arvinxx commented Sep 10, 2024

image

这个是啥情况?

@RubuJam
Copy link
Contributor Author

RubuJam commented Sep 10, 2024

所有有样式变更的地方都贴下图?

调整等待中的文本字间距,这个我不知道怎么截图
另外一个更改,就只是换了一下文本

其余更改均已贴图

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Post the following pictures wherever there are style changes?

Adjust the word spacing of the text of "Waiting". I don't know how to take a screenshot of this.
Another change is just changing the text

@arvinxx
Copy link
Contributor

arvinxx commented Sep 10, 2024

调整等待中的文本字间距,这个我不知道怎么截图

这个是哪里的等待中的文本

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Adjust the word spacing of the waiting text. I don’t know how to take a screenshot of this.

Where is this waiting text?

@RubuJam
Copy link
Contributor Author

RubuJam commented Sep 10, 2024

image

这个是啥情况?

这个是图片的删除按钮,红色的部分是图片,而不是按钮

@arvinxx
Copy link
Contributor

arvinxx commented Sep 10, 2024

其他应该没啥问题了,你把 ... 加上吧。可以先去掉cn 里的那一条,然后跑一次 i18n ,脚本会自动移除cn里没有的 key。 然后再把这一条加回去

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


There should be no problem with the rest. Just add.... You can first remove the entry in cn and then run i18n. The script will automatically remove the key that is not in cn. Then add this one back

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Adjust the word spacing of the waiting text. I don’t know how to take a screenshot of this.

Where is this waiting text?

Here, the main modifications are made for Japanese and Korean languages.
image

@RubuJam
Copy link
Contributor Author

RubuJam commented Sep 10, 2024

其他应该没啥问题了,你把 ... 加上吧。可以先去掉cn 里的那一条,然后跑一次 i18n ,脚本会自动移除cn里没有的 key。 然后再把这一条加回去

那我明天去改一下

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Everything else should be fine. Just add .... You can first remove the entry in cn, and then run i18n. The script will automatically remove the key that is not in cn. Then add this one back

Then I'll change it tomorrow

@RubuJam RubuJam requested a review from arvinxx September 11, 2024 04:12
@RubuJam RubuJam marked this pull request as draft September 11, 2024 04:18
@RubuJam RubuJam marked this pull request as ready for review September 11, 2024 04:19
@RubuJam RubuJam closed this Sep 11, 2024
@RubuJam RubuJam reopened this Sep 11, 2024
@RubuJam
Copy link
Contributor Author

RubuJam commented Sep 11, 2024

修改完毕 @arvinxx

Modification completed @arvinxx

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 7:26am

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 11, 2024
@arvinxx arvinxx changed the title 💄 style(ui): Modify and repair UI layout 💄 style(ui): improve UI layout and text Sep 11, 2024
@arvinxx arvinxx merged commit 7c08f29 into lobehub:main Sep 11, 2024
11 of 12 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @RubuJam ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@RubuJam RubuJam deleted the style/patch-2 branch September 11, 2024 07:35
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
### [Version&nbsp;1.16.4](v1.16.3...v1.16.4)
<sup>Released on **2024-09-11**</sup>

#### 💄 Styles

- **ui**: Improve UI layout and text.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **ui**: Improve UI layout and text, closes [#3762](#3762) ([7c08f29](7c08f29))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.16.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Sep 11, 2024
## [Version&nbsp;1.59.0](v1.58.16...v1.59.0)
<sup>Released on **2024-09-11**</sup>

#### ✨ Features

- **misc**: Add Fireworks AI Model Provider, Add Spark model provider.

#### 🐛 Bug Fixes

- **misc**: Add `LLM_VISION_IMAGE_USE_BASE64` to support local s3 in vision model.

#### 💄 Styles

- **ui**: Improve UI layout and text.
- **misc**: Reorder the provider list, Update CustomLogo, update spark check model to spark-lite & default disable useless model, update Upstage model list.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Add Fireworks AI Model Provider, closes [lobehub#3392](https://github.com/bentwnghk/lobe-chat/issues/3392) [lobehub#48](https://github.com/bentwnghk/lobe-chat/issues/48) ([fa0d84d](fa0d84d))
* **misc**: Add Spark model provider, closes [lobehub#3098](https://github.com/bentwnghk/lobe-chat/issues/3098) [lobehub#25](https://github.com/bentwnghk/lobe-chat/issues/25) ([fc85c20](fc85c20))

#### What's fixed

* **misc**: Add `LLM_VISION_IMAGE_USE_BASE64` to support local s3 in vision model, closes [lobehub#3887](https://github.com/bentwnghk/lobe-chat/issues/3887) ([16e57ed](16e57ed))

#### Styles

* **ui**: Improve UI layout and text, closes [lobehub#3762](https://github.com/bentwnghk/lobe-chat/issues/3762) ([7c08f29](7c08f29))
* **misc**: Reorder the provider list, closes [lobehub#3886](https://github.com/bentwnghk/lobe-chat/issues/3886) ([4d641f5](4d641f5))
* **misc**: Update CustomLogo, closes [lobehub#3874](https://github.com/bentwnghk/lobe-chat/issues/3874) ([dd7c8df](dd7c8df))
* **misc**: Update spark check model to spark-lite & default disable useless model, closes [lobehub#3885](https://github.com/bentwnghk/lobe-chat/issues/3885) ([9d7e47c](9d7e47c))
* **misc**: Update Upstage model list, closes [lobehub#3890](https://github.com/bentwnghk/lobe-chat/issues/3890) ([82e2570](82e2570))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💄 Design Design an style | 样式问题 lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants