-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildfire: do not always hose hidden temple #967
Conversation
the first commit looks to be a duplicate of #964 |
Looks to be a github issue isaacs/github#750 Should be a non-issue, otherwise I can open a new PR |
If making a new PR fixes the issue, I'd prefer you do that. Even if this is no issue technically it does muddy the history of this repo. Just my 2 cents |
huh. interesting. well ok then. Maybe rebasing this PR will fix it? |
273e387
to
a6adbda
Compare
Did some witch magic and the diffs are now normal. I think the issue is that I pulled from my own master branch which had commits that were not the same sha as the official branch. Did you need me to edit the code as per @taltamir's thoughts? |
Yes. With how large this script is any improvements to readability is good imo |
you should rebase your master branch to the lass master branch while dropping all commits from it. this will make it identical to the LASS:master branch.
please do |
Description
If the player has already progressed pass hidden temple, there's no need to force a hose down of the area in wildfire path.
How Has This Been Tested?
Hasn't
Checklist: