Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returned diskname is not correct #16

Closed
Sellto opened this issue Dec 5, 2019 · 14 comments
Closed

returned diskname is not correct #16

Sellto opened this issue Dec 5, 2019 · 14 comments

Comments

@Sellto
Copy link

Sellto commented Dec 5, 2019

Hello,

I try to use your driver (v2) as a node-driver in Rancher to provide a Kubernetes cluster.
But i have a issue, the logs return me this error :
Error creating machine: Error in driver during machine creation: returned diskname is not correct.

Rancher Error

However, as you can see in the screen shot, the disk is correctly created but the VM isn't created:

proxmox

Here is my proxmox node template in Rancher:

proxmox option

Any idea to resolve this problem?

lnxbil added a commit that referenced this issue Dec 5, 2019
@lnxbil
Copy link
Owner

lnxbil commented Dec 5, 2019

Hi and thank you for using the driver with kubernetes! It's still on my todo list :-D

I recently introduced a check that should try to detect any errors with the disk creation, so that is to blame for that. Unfortunately, it sends it's expected and actual data in the second line of the error message, that is not displayed in your output (maybe the software expects only one line of error).

Anyway, I have a possible workaround but no machine I can actually test it. Would you be so kind?

https://github.com/lnxbil/docker-machine-driver-proxmox-ve/releases/tag/possible-fix-for-16

@Sellto
Copy link
Author

Sellto commented Dec 5, 2019

I can be the tester ;)

So, i have just tested your proposed release but that don't resolve the issue.
However i have new informations from the logs:

Capture d’écran 2019-12-05 à 12 45 35

I hope it help you more.

@lnxbil
Copy link
Owner

lnxbil commented Dec 5, 2019

Thank you, now with a better error message I can deal with. brb

lnxbil added a commit that referenced this issue Dec 5, 2019
@lnxbil
Copy link
Owner

lnxbil commented Dec 5, 2019

So, another prerelease

@Sellto
Copy link
Author

Sellto commented Dec 5, 2019

We are going forward.

The VM is correctly deploy with rancherOS.
However I have a new error :

Capture d’écran 2019-12-05 à 13 06 53

I think it's a other issue and I don't know if that come from the driver. What do you think about this error?

a possible way : the name of the driver don't match...

@lnxbil
Copy link
Owner

lnxbil commented Dec 5, 2019

Yes, this is a new and external error. Strange that it is found in the first place to create the VM. In which directory did you copy the driver file?

@Sellto
Copy link
Author

Sellto commented Dec 5, 2019

It think i have a possible solution :
change proxmox to proxmoxve into the main.go ... i think it can do the job

@Sellto
Copy link
Author

Sellto commented Dec 5, 2019

Yes, this is a new and external error. Strange that it is found in the first place to create the VM. In which directory did you copy the driver file?

In rancher you upload the driver from the interface... and then he store it somewhere...
but i try a fork of you repo where the import name was proxmoxve and i don't have this issue.

I think it's important to work on your repo because it is pointed by rancher.

@lnxbil
Copy link
Owner

lnxbil commented Dec 5, 2019

Just to be clear, changing this works?

diff --git a/cmd/docker-machine-driver-proxmox-ve/main.go b/cmd/docker-machine-driver-proxmox-ve/main.go
index 5ca2279..7a2df1f 100644
--- a/cmd/docker-machine-driver-proxmox-ve/main.go
+++ b/cmd/docker-machine-driver-proxmox-ve/main.go
@@ -2,9 +2,9 @@ package main
 
 import (
        "github.com/docker/machine/libmachine/drivers/plugin"
-       proxmox "github.com/lnxbil/docker-machine-driver-proxmox-ve"
+       proxmoxve "github.com/lnxbil/docker-machine-driver-proxmox-ve"
 )
 
 func main() {
-       plugin.RegisterDriver(proxmox.NewDriver("default", ""))
+       plugin.RegisterDriver(proxmoxve.NewDriver("default", ""))
 }

@lnxbil
Copy link
Owner

lnxbil commented Dec 5, 2019

Ah, nevermind. Found your fork.

@lnxbil
Copy link
Owner

lnxbil commented Dec 5, 2019

So, changed it in 5014644 and forgot to reference this issue.

@lnxbil
Copy link
Owner

lnxbil commented Dec 5, 2019

I've not uploaded a new release yet, you're capable of building your own as you revealed above :-D

@Sellto
Copy link
Author

Sellto commented Dec 5, 2019

i encourage you to build and create the pre-release 3... to avoid problem with our possible different golang version

@lnxbil
Copy link
Owner

lnxbil commented Dec 5, 2019

i encourage you to build and create the pre-release 3... to avoid problem with our possible different golang version

Sure thing ... online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants