Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added invoiceImmediately and disableProrations parameters to updateSubscriptionItem function. #61

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

keyding
Copy link
Contributor

@keyding keyding commented Feb 17, 2024

Added invoiceImmediately and disableProrations parameters to updateSubscriptionItem function.

Copy link

changeset-bot bot commented Feb 17, 2024

🦋 Changeset detected

Latest commit: 02886df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lemonsqueezy/lemonsqueezy.js Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@elie222
Copy link

elie222 commented Feb 21, 2024

Looking forward to seeing this added.

@elie222
Copy link

elie222 commented Feb 26, 2024

Rough idea on timeline for this?

Copy link
Collaborator

@brankoconjic brankoconjic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@brankoconjic brankoconjic merged commit 93381d9 into lmsqueezy:main Feb 28, 2024
@brankoconjic brankoconjic linked an issue Feb 28, 2024 that may be closed by this pull request
@keyding keyding deleted the feat/update-subscription branch February 29, 2024 03:02
@elie222
Copy link

elie222 commented Feb 29, 2024

Has a deprecated warning. Because the function has the same name:

CleanShot 2024-02-29 at 10 48 54@2x

@elie222
Copy link

elie222 commented Feb 29, 2024

It's fine when I use it though:

CleanShot 2024-02-29 at 10 49 39@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for invoice_immediately in subscription-items
3 participants