Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AI SDK metadata to the trace level #277

Merged
merged 1 commit into from
Dec 18, 2024
Merged

add AI SDK metadata to the trace level #277

merged 1 commit into from
Dec 18, 2024

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Dec 14, 2024

  • remove the input messages from the attributes themselves, similar to what we do for regular OpenLLMetry input output attributes

Important

Extend SpanAttributes metadata with AI SDK telemetry metadata and remove ai.prompt.messages from attributes.

  • Behavior:
    • Extend metadata() in SpanAttributes to include AI SDK telemetry metadata.
    • Remove ai.prompt.messages from attributes in should_keep_attribute().
  • Refactoring:
    • Refactor get_flattened_association_properties() to use get_flattened_properties() in spans.rs.
  • Constants:
    • Remove trailing dot from ASSOCIATION_PROPERTIES_PREFIX.

This description was created by Ellipsis for 7cb7b38. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7cb7b38 in 2 minutes and 21 seconds

More details
  • Looked at 69 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. app-server/src/traces/span_attributes.rs:28
  • Draft comment:
    The ASSOCIATION_PROPERTIES_PREFIX constant was changed to remove the trailing dot. Ensure that all usages of this constant in the codebase append a dot where necessary to maintain the correct format.
  • Reason this comment was not posted:
    Marked as duplicate.
2. app-server/src/traces/spans.rs:250
  • Draft comment:
    Ensure that the attribute_prefix includes a trailing dot if needed, as the ASSOCIATION_PROPERTIES_PREFIX constant was changed to remove the trailing dot. This affects the get_flattened_properties function and its usage in get_flattened_association_properties.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_h9xFqd0nr0oLtbqH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit 2944101 into dev Dec 18, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the aisdk-metadata branch December 18, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant