Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable next #39

Merged
merged 5 commits into from
Dec 24, 2024
Merged

Disable next #39

merged 5 commits into from
Dec 24, 2024

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Dec 22, 2024 •
edited
Loading

Status:
code complete

Notes:
I added many comments in code, because otherwise what we are doing is not immediately straightforward.

Testing done:

  • Write simple unit tests for some of the functionality, e.g. attributes
  • Test manually more with Next.js
  • Try testing with Next.js 15 without the experimentalInstrumentation flag

Testing I haven't figured out how to do quickly:

  • Test the set size

skull8888888
skull8888888 reviewed Dec 22, 2024
View reviewed changes
Copy link
Collaborator

@skull8888888 skull8888888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, I don't know why you think it looks wild. Let's test it with actual nextjs app.

src/sdk/tracing/index.ts Outdated Show resolved Hide resolved
src/sdk/tracing/index.ts Show resolved Hide resolved
@dinmukhamedm dinmukhamedm marked this pull request as ready for review December 24, 2024 06:42
@dinmukhamedm dinmukhamedm merged commit a98318c into main Dec 24, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the disable-next branch December 24, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skull8888888 skull8888888 skull8888888 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dinmukhamedm @skull8888888