restore best-fit parameter values for high accuracy values of constrained values #907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes sure that the best-fit (or current) values are restored to their original values in
Parameters.create_uvars
.As shown in #905, values for constraint expressions may be off slightly (around uncertainty or machine precision) without this fix.
Type of Changes
Tested on
Python: 3.10.10 | packaged by conda-forge | (main, Mar 24 2023, 20:17:34) [Clang 14.0.6 ]
lmfit: 1.2.2.post0+g8b2038a.d20230727, scipy: 1.11.1, numpy: 1.25.1, asteval: 0.9.31, uncertainties: 3.1.7
Verification
Have you