Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed default value to switch to python vs tensorflow based iteration #694

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

timsainb
Copy link
Collaborator

This just changes the default switch from iterating with a tensorflow backend vs a python backend at a smaller dataset size.

I was experimenting around a bit and found issues with datasets > 1GB with the tensorflow based iteration. So it seems safer to make the default the python-based iteration/sampling for any dataset bigger than 512MB. The speed gains for the tensorflow-based iteration aren't too big anyway.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.697% when pulling 5fb62c8 on timsainb:tf_gather_indices_in_python into de88b39 on lmcinnes:master.

@lmcinnes lmcinnes merged commit 42b3f1f into lmcinnes:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants