Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Introduce SplitButton component #DS-1605 #1919

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Feb 6, 2025

Description

Additional context

Note

The divider between the buttons has been updated and no longer has a gap at the top and bottom.

Issue reference

Component SplitButton | Web

@pavelklibani pavelklibani self-assigned this Feb 6, 2025
@pavelklibani pavelklibani force-pushed the feat/ds-1605-split-button branch from 73e57cd to 88af225 Compare February 6, 2025 15:45
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 2a264a6
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67adceb895656900088b13f1
😎 Deploy Preview https://deploy-preview-1919--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 2a264a6
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67adceb858655200082d237f

@pavelklibani pavelklibani force-pushed the feat/ds-1605-split-button branch from 82b6dff to 459c993 Compare February 7, 2025 10:00
@pavelklibani pavelklibani changed the title Feat(web): Introduce SplitButton component #DS-1605 Feat(web): Introduce SplitButton component #DS-1605 Feb 7, 2025
@pavelklibani pavelklibani marked this pull request as ready for review February 7, 2025 10:57
@katerinarehorkova
Copy link

On mobile phones, there is issue with the position of DropdownPopover, it's placed outside of the container and creates a horizontal scrollbar.

@pavelklibani
Copy link
Contributor Author

On mobile phones, there is issue with the position of DropdownPopover, it's placed outside of the container and creates a horizontal scrollbar.

The dropdown has been moved to the bottom-end, so it should no longer cause the scrollbar.

@pavelklibani pavelklibani force-pushed the feat/ds-1605-split-button branch from 1470d34 to cd48467 Compare February 7, 2025 13:09
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't understand any of my comments, don't hesitate to contact me directly :)

packages/web/src/scss/components/Button/_Button.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/SplitButton/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/SplitButton/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/SplitButton/index.html Outdated Show resolved Hide resolved
@katerinarehorkova
Copy link

there is an issue with SVG icons in FF, it's deformed, because of flex, it's fixed by adding flex-shrink: 0 on the SVG
image

@pavelklibani pavelklibani force-pushed the feat/ds-1605-split-button branch from 973b6d3 to 8e22c6b Compare February 12, 2025 20:23
@pavelklibani
Copy link
Contributor Author

there is an issue with SVG icons in FF, it's deformed, because of flex, it's fixed by adding flex-shrink: 0 on the SVG image

Fixed, thank you!

@pavelklibani pavelklibani force-pushed the feat/ds-1605-split-button branch from 8e22c6b to 06f76f9 Compare February 13, 2025 09:38
@crishpeen crishpeen added run-visual-tests Runs visual regression testing on this PR feature New feature or request labels Feb 13, 2025
@pavelklibani pavelklibani force-pushed the feat/ds-1605-split-button branch from 06f76f9 to 2a264a6 Compare February 13, 2025 10:51
@pavelklibani pavelklibani merged commit 19b5f86 into main Feb 13, 2025
23 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1605-split-button branch February 13, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants