Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web-react): Introduce NavigationAvatar subcomponent #DS-1666 #1916

Merged

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Feb 5, 2025

Description

Additional context

Issue reference

@curdaj curdaj changed the base branch from main to feature/web-navigation-avatar February 5, 2025 14:30
@github-actions github-actions bot added the feature New feature or request label Feb 5, 2025
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 45e7f4a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67ac92a7bfe5bf0008602067

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 45e7f4a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67ac92a813397a0008169c36
😎 Deploy Preview https://deploy-preview-1916--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0 (🔴 down 96 from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@curdaj curdaj added the run-visual-tests Runs visual regression testing on this PR label Feb 5, 2025
@curdaj curdaj marked this pull request as ready for review February 5, 2025 15:29
@curdaj curdaj force-pushed the feature/web-navigation-avatar-react branch 2 times, most recently from 5fbdb59 to 1d1d116 Compare February 6, 2025 08:40
@curdaj curdaj requested a review from crishpeen February 6, 2025 10:29
@curdaj curdaj force-pushed the feature/web-navigation-avatar-react branch from 233f959 to a12ae21 Compare February 6, 2025 12:49
@crishpeen crishpeen force-pushed the feature/web-navigation-avatar branch from ef8b22e to 403ea06 Compare February 11, 2025 13:07
@crishpeen crishpeen force-pushed the feature/web-navigation-avatar branch 2 times, most recently from 8dbdba3 to afbb8e2 Compare February 11, 2025 15:48
@curdaj curdaj force-pushed the feature/web-navigation-avatar-react branch from 5270d85 to 81e01f3 Compare February 11, 2025 16:10
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curdaj curdaj force-pushed the feature/web-navigation-avatar-react branch from 3a5f787 to 45e7f4a Compare February 12, 2025 12:23
@curdaj curdaj merged commit 0815b6d into feature/web-navigation-avatar Feb 12, 2025
23 checks passed
@curdaj curdaj deleted the feature/web-navigation-avatar-react branch February 12, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants