Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Remove validationState from passed props of the TextFieldBase style hook #1912

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

literat
Copy link
Collaborator

@literat literat commented Feb 4, 2025

Description

Additional context

  • Warning: React does not recognize the validationState prop on a DOM element.

Issue reference

@literat literat added the run-visual-tests Runs visual regression testing on this PR label Feb 4, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 4, 2025
Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 06a5570
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67a5d0a6ea399900084275aa
😎 Deploy Preview https://deploy-preview-1912--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 06a5570
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67a5d0a799d4eb0008abd339
😎 Deploy Preview https://deploy-preview-1912--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat marked this pull request as ready for review February 6, 2025 15:28
@literat literat force-pushed the fix/web-react-textfield-dom-prop branch from ac10c79 to 1c23413 Compare February 6, 2025 15:28
…tFieldBase style hook

  * Warning: React does not recognize the `validationState` prop on a DOM element.
@pavelklibani pavelklibani force-pushed the fix/web-react-textfield-dom-prop branch from 1c23413 to 06a5570 Compare February 7, 2025 09:21
@pavelklibani pavelklibani merged commit fd14e81 into main Feb 7, 2025
23 checks passed
@pavelklibani pavelklibani deleted the fix/web-react-textfield-dom-prop branch February 7, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants