-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradio web server demo error #3596
Open
tsunghan-wu
wants to merge
58
commits into
lm-sys:main
Choose a base branch
from
tsunghan-wu:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+28,423
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch trial, and make sure our code aligns with the format
Merge handle function native multiturn
…n-wu/FastChat into handle_function_native_multiturn
…n (2) Cleanup the display a bit
Multi agent
Handle function native multiturn
update response
Web search
Support Various APIs
merging evaluation results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A quick fix for the single-model Gradio web server. The original code was passing a list to the
Context
object, which caused an AttributeError. This PR corrects that issue by ensuring the properContext
object is passed.Related issue number (if applicable):
#3595
Checks:
format.sh
to lint the changes in this PR.Test:
Follow the instructions here, and the error no longer occurs after running the controller, model worker, and Gradio worker, then opening the browser.