Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for llvm/llvm-project#54130 #112

Open
wants to merge 1 commit into
base: release/14.x
Choose a base branch
from
Open

PR for llvm/llvm-project#54130 #112

wants to merge 1 commit into from

Commits on Mar 1, 2022

  1. [DebugInfo][InstrRef][NFC] Use unique_ptr instead of raw pointers 

    InstrRefBasedLDV allocates some big tables of ValueIDNum, to store live-in
and live-out block values in, that then get passed around as pointers
everywhere. This patch wraps the allocation in a std::unique_ptr, names
some types based on unique_ptr, and passes references to those around
instead. There's no functional change, but it makes it clearer to the
reader that references to these tables are borrowed rather than owned, and
we get some extra validity assertions too.

Differential Revision: https://reviews.llvm.org/D118774

(cherry picked from commit ab49dce)
    @jmorse @llvmbot
    jmorse authored and llvmbot committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    d58ec5e View commit details
    Browse the repository at this point in the history