Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onnx] handle dynamic padSize tensor in onnx.Pad #3214

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[onnx] handle dynamic padSize tensor in onnx.Pad #3214

merged 1 commit into from
Apr 24, 2024

Conversation

PhaneeshB
Copy link
Collaborator

@PhaneeshB PhaneeshB commented Apr 23, 2024 •
edited
Loading

  • Fix pad size to data_rank for dynamic paddingSize Tensor.
  • This fix is in accordance with input specification for onnx.Pad
  • Impl will need to be updated for dynamic padSize when support for axes is added.

This was referenced Apr 23, 2024
Closed
Open
Open
AmosLewis
AmosLewis approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@AmosLewis AmosLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@penguin-wwy penguin-wwy merged commit f77d883 into llvm:main Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmosLewis AmosLewis AmosLewis approved these changes

@vivekkhandelwal1 vivekkhandelwal1 Awaiting requested review from vivekkhandelwal1

@rsuderman rsuderman Awaiting requested review from rsuderman

@Shukla-Gaurav Shukla-Gaurav Awaiting requested review from Shukla-Gaurav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhaneeshB @AmosLewis @penguin-wwy