[llvm][CodeGen] Added missing initialization failure information for window scheduler #99449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-hexagon Author: Kai Yan (kaiyan96) ChangesAdded missing initialization failure information for window scheduler. Full diff: https://github.com/llvm/llvm-project/pull/99449.diff 2 Files Affected:
diff --git a/llvm/lib/CodeGen/WindowScheduler.cpp b/llvm/lib/CodeGen/WindowScheduler.cpp
index 0777480499e55..3fe8a1aaafd12 100644
--- a/llvm/lib/CodeGen/WindowScheduler.cpp
+++ b/llvm/lib/CodeGen/WindowScheduler.cpp
@@ -232,8 +232,11 @@ bool WindowScheduler::initialize() {
return false;
}
for (auto &Def : MI.all_defs())
- if (Def.isReg() && Def.getReg().isPhysical())
+ if (Def.isReg() && Def.getReg().isPhysical()) {
+ LLVM_DEBUG(dbgs() << "Physical registers are not supported in "
+ "window scheduling!\n");
return false;
+ }
}
if (SchedInstrNum <= WindowRegionLimit) {
LLVM_DEBUG(dbgs() << "There are too few MIs in the window region!\n");
diff --git a/llvm/test/CodeGen/Hexagon/swp-ws-fail-2.mir b/llvm/test/CodeGen/Hexagon/swp-ws-fail-2.mir
index 601b98dca8e20..be75301b016ed 100644
--- a/llvm/test/CodeGen/Hexagon/swp-ws-fail-2.mir
+++ b/llvm/test/CodeGen/Hexagon/swp-ws-fail-2.mir
@@ -3,6 +3,7 @@
# RUN: -window-sched=force -filetype=null -verify-machineinstrs 2>&1 \
# RUN: | FileCheck %s
+# CHECK: Physical registers are not supported in window scheduling!
# CHECK: The WindowScheduler failed to initialize!
---
|
This was referenced Jul 18, 2024
Merged
arsenm
approved these changes
Jul 18, 2024
arsenm
reviewed
Jul 18, 2024
| @@ -232,8 +232,11 @@ bool WindowScheduler::initialize() { | |||
| return false; | |||
| } | |||
| for (auto &Def : MI.all_defs()) | |||
| if (Def.isReg() && Def.getReg().isPhysical()) | |||
| if (Def.isReg() && Def.getReg().isPhysical()) { | |||
| LLVM_DEBUG(dbgs() << "Physical registers are not supported in " | |||
There was a problem hiding this comment.
Indeed, there is more debug information. Our consideration is that as a newly proposed software pipelining algorithm, the window algorithm may require more detailed output information to facilitate analysis and debugging.
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
…window scheduler (#99449) Summary: Added missing initialization failure information for window scheduler. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250707
kaiyan96
added a commit
to kaiyan96/llvm-project
that referenced
this pull request
Aug 12, 2024
…window scheduler (llvm#99449) Added missing initialization failure information for window scheduler.
tru
pushed a commit
to kaiyan96/llvm-project
that referenced
this pull request
Aug 20, 2024
…window scheduler (llvm#99449) Added missing initialization failure information for window scheduler.
tru
pushed a commit
to kaiyan96/llvm-project
that referenced
this pull request
Sep 1, 2024
…window scheduler (llvm#99449) Added missing initialization failure information for window scheduler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing initialization failure information for window scheduler.