[libc++][TZDB] Disables a failing test. #95659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test fails depending on the timezone database used. Disable it for now so it can be properly investigated later.
mordante
changed the title
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) ChangesThe test fails depending on the timezone database used. Disable it for now so it can be properly investigated later. Full diff: https://github.com/llvm/llvm-project/pull/95659.diff 1 Files Affected:
diff --git a/libcxx/test/std/time/time.zone/time.zone.timezone/time.zone.members/get_info.local_time.pass.cpp b/libcxx/test/std/time/time.zone/time.zone.timezone/time.zone.members/get_info.local_time.pass.cpp
index d424b41673b14..76dd8bc746fcd 100644
--- a/libcxx/test/std/time/time.zone/time.zone.timezone/time.zone.members/get_info.local_time.pass.cpp
+++ b/libcxx/test/std/time/time.zone/time.zone.timezone/time.zone.members/get_info.local_time.pass.cpp
@@ -13,6 +13,9 @@
// XFAIL: libcpp-has-no-experimental-tzdb
// XFAIL: availability-tzdb-missing
+// TODO TZDB Investigate why this fails.
+// UNSUPPORTED: target={{.*}}
+
// <chrono>
// class time_zone;
|
EricWF
reviewed
Jun 15, 2024
| @@ -13,6 +13,9 @@ | |||
| // XFAIL: libcpp-has-no-experimental-tzdb | |||
| // XFAIL: availability-tzdb-missing | |||
|
|
|||
| // TODO TZDB Investigate why this fails. | |||
| // UNSUPPORTED: target={{.*}} | |||
There was a problem hiding this comment.
It would be nice to have more information about exactly what fails and how to reproduce it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fails depending on the timezone database used. Disable it for now so it can be properly investigated later.