Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][math][c23] Temporarily disable float16 on RISC-V #94984

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

overmighty
Copy link
Member

@overmighty
Copy link
Member Author

cc @lntue

@llvmbot llvmbot added the libc label Jun 10, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jun 10, 2024

@llvm/pr-subscribers-libc

Author: OverMighty (overmighty)

Changes

See Buildbot failures:


Full diff: https://github.com/llvm/llvm-project/pull/94984.diff

1 Files Affected:

  • (modified) libc/include/llvm-libc-macros/float16-macros.h (+2-1)
diff --git a/libc/include/llvm-libc-macros/float16-macros.h b/libc/include/llvm-libc-macros/float16-macros.h
index 9f17503d85130..3f819ad53df71 100644
--- a/libc/include/llvm-libc-macros/float16-macros.h
+++ b/libc/include/llvm-libc-macros/float16-macros.h
@@ -10,7 +10,8 @@
 #define LLVM_LIBC_MACROS_FLOAT16_MACROS_H
 
 #if defined(__FLT16_MANT_DIG__) &&                                             \
-    (!defined(__GNUC__) || __GNUC__ >= 13 || defined(__clang__))
+    (!defined(__GNUC__) || __GNUC__ >= 13 || defined(__clang__)) &&            \
+    !defined(__riscv)
 #define LIBC_TYPES_HAS_FLOAT16
 #endif
 

@lntue lntue merged commit c5b68a9 into llvm:main Jun 10, 2024
6 of 7 checks passed
@HerrCai0907 HerrCai0907 mentioned this pull request Jun 13, 2024
@nickdesaulniers
Copy link
Member

What's the plan for getting this re-enabled? Is the a bug on file? If not, please file one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants