Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV] Remove stale comments. NFC #94925

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Jun 10, 2024

We no longer have _TU pseudo instructions.

I'm not sure if we have any unsuffixed instructions w/o mask w/ passthru w/o policy operand. That case is not covered by the earlier comments. I could find any from a quick audit.

We no longer have _TU pseudo instructions.

I'm not sure if we have any unsuffixed instructions w/o mask w/ passthru
w/o policy operand. That case is not covered by the earlier comments.
I could find any from a quick audit.
@llvmbot
Copy link
Collaborator

llvmbot commented Jun 10, 2024

@llvm/pr-subscribers-backend-risc-v

Author: Craig Topper (topperc)

Changes

We no longer have _TU pseudo instructions.

I'm not sure if we have any unsuffixed instructions w/o mask w/ passthru w/o policy operand. That case is not covered by the earlier comments. I could find any from a quick audit.


Full diff: https://github.com/llvm/llvm-project/pull/94925.diff

1 Files Affected:

  • (modified) llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td (-5)
diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td b/llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
index 77d3644687fdd..a206974e53e51 100644
--- a/llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
+++ b/llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
@@ -67,11 +67,6 @@
 ///   that terminology in code frequently refers to these as "TA" which is
 ///   confusing.  We're in the process of migrating away from this
 ///   representation.
-/// * _TU w/o policy operand -- Has a passthrough operand, and always
-///   represents the tail undisturbed state.
-/// * _TU w/policy operand - Can represent all three policy states.  If
-///   passthrough is IMPLICIT_DEF (or NoReg), then represents "undefined".
-///   Otherwise, policy operand and tablegen flags drive the interpretation.
 ///
 //===----------------------------------------------------------------------===//
 

Copy link
Collaborator

@preames preames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topperc topperc merged commit 18658db into llvm:main Jun 10, 2024
9 checks passed
@topperc topperc deleted the pr/underscore-tu-comment branch June 10, 2024 16:11
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Jun 12, 2024
We no longer have _TU pseudo instructions.

I'm not sure if we have any unsuffixed instructions w/o mask w/ passthru
w/o policy operand. That case is not covered by the earlier comments. I
could not find any from a quick audit.
@HerrCai0907 HerrCai0907 mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants