Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAG: Replace bitwidth with type in suffix in atomic tablegen ops #94845

Merged
merged 3 commits into from
Jun 13, 2024

Commits on Jun 10, 2024

  1. DAG: Replace bitwidth with type in suffix in atomic tablegen ops

    For FP atomics involving bfloat vs. half, we need to distinguish the
    type and not rely on the bitwidth alone. For my purposes, an alternative
    would be to relax the atomic predicate MemoryVT pattern check with a memory
    size only check. Since there are no extending operations involved,
    the pattern value check should be unambiguous.
    
    For some reason when using the _32 variants for atomicrmw fadd, I was able to
    select v2f16 but v2bf16 would fail.
    
    Changes mostly done with sed, e.g.
    sed -E -i -r 's/atomic_load_(add|swap|sub|and|clr|or|xor|nand|min|max|umin|umax|swap)_([0-9]+)/atomic_load_\1_i\2/' llvm/lib/Target/*/*.td
    arsenm committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2f099ab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f1eda0 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Indentation

    arsenm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    fad8630 View commit details
    Browse the repository at this point in the history