[lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types

[Michael137]

This is a follow-up of #92328 (comment)

Clang attaches DW_AT_declaration to static inline data members and dsymutil indexes these constants. Skipping these caused the expression evaluator to fail to find such constants when using DWARFv5.

Fixes TestConstStaticIntegralMember.py on DWARFv5.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Michael Buch (Michael137)

Changes

This is a follow-up of #92328 (comment)

Clang attaches DW_AT_declaration to static inline data members and dsymutil indexes these constants. Skipping these caused the expression evaluator to fail to find such constants when using DWARFv5.

Fixes TestConstStaticIntegralMember.py on DWARFv5.

---

Full diff: https://github.com/llvm/llvm-project/pull/94400.diff

1 Files Affected:

• (modified) lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp (+2-1)

diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
index 56717bab1ecd8..6330470b970e7 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
@@ -87,7 +87,8 @@ bool DebugNamesDWARFIndex::ProcessEntry(
     return true;
   // Clang erroneously emits index entries for declaration DIEs in case when the
   // definition is in a type unit (llvm.org/pr77696). Weed those out.
-  if (die.GetAttributeValueAsUnsigned(DW_AT_declaration, 0))
+  if (die.IsStructUnionOrClass() &&
+      die.GetAttributeValueAsUnsigned(DW_AT_declaration, 0))
     return true;
   return callback(die);
 }

[Michael137]

We might want to consider not omitting these constants into the index with dsymutil (since it's not spec conforming). And instead fix the expression evaluator to find the constants from context (but iirc that was a non-trivial undertaking).