[RISCV] Convert remaining constant splats in tests to use splat shorthand. NFC #88099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hand. NFC This follows on from llvm#87616, but includes the tests with codegen differences. These are presumably due to the fact that the splat is now a constant expression. They don't seem to affect anything that we were specifically testing for.
lukel97
requested review from
dtcxzyw,
preames,
sun-jacobi,
topperc and
wangpc-pp
lukel97
commented
Apr 9, 2024
| ; RV64ZVE32F-NEXT: ret | ||
| %mhead = insertelement <4 x i1> poison, i1 1, i32 0 |
There was a problem hiding this comment.
For these truemask_i1 tests the incoming DAG was scalarized. But instcombine will convert this into a constant expression anyway, so we shouldn't see this in practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on from #87616, but includes the tests with codegen differences. These are presumably due to the fact that the splat is now a constant expression. They don't seem to affect anything that we were specifically testing for.