Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DebugInfoD tests + fixing issues exposed by tests #85693

Merged
merged 6 commits into from
Mar 21, 2024
Merged

DebugInfoD tests + fixing issues exposed by tests #85693

merged 6 commits into from
Mar 21, 2024

Commits on Mar 20, 2024

  1. Tests (w/fixes) for initial DebugInfoD LLDB integration 

    Summary:
While adding tests for DebugInfoD integration, there were a couple issues that came up:
DWP from /debuginfo for a stripped binary needs to return symbols from /executable

Test Plan: Added some API tests

Reviewers: gclayton, hyubo

Subscribers:

Tasks: T179375937

Tags: debuginfod

Differential Revision: https://phabricator.intern.facebook.com/D54953389
    @kevinfrei
    kevinfrei committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    fc0eda9 View commit details
    Browse the repository at this point in the history

  2. Skip the tests for non-*nix platforms

    @kevinfrei
    kevinfrei committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    edf4924 View commit details
    Browse the repository at this point in the history

  3. Removed an inadvertent auto-formatter change

    @kevinfrei
    kevinfrei committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    972b8e2 View commit details
    Browse the repository at this point in the history

  4. Fixed formatting for the Python tests

    @kevinfrei
    kevinfrei committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c2ca52d View commit details
    Browse the repository at this point in the history

  5. Address PR feedback from JDevlieghere

    @kevinfrei
    kevinfrei committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ba22dea View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Updated with @clayborg's feedback

    @kevinfrei
    kevinfrei committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2b38c7d View commit details
    Browse the repository at this point in the history