Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Orc] Add NotifyCreated callback for LLJITBuilder" #84398

Closed
wants to merge 1 commit into from
Closed

Revert "[Orc] Add NotifyCreated callback for LLJITBuilder" #84398

wants to merge 1 commit into from

Conversation

joker-eph
Copy link
Collaborator

@joker-eph joker-eph added the skip-precommit-approval PR for CI feedback, not intended for review label Mar 7, 2024
@joker-eph joker-eph requested a review from weliveindetail March 7, 2024 23:16
@weliveindetail
Copy link
Member

Sorry, that's a quick fix. Can I push it now directly without revert?

@joker-eph
Copy link
Collaborator Author

5d33f71 should fix it I think

@weliveindetail
Copy link
Member

Ok, I see you just fixed it with 5d33f71 Thanks!

@joker-eph joker-eph closed this Mar 7, 2024
@joker-eph joker-eph deleted the revert-84175-lljit-builder-notify-created branch March 7, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weliveindetail weliveindetail Awaiting requested review from weliveindetail

Assignees
No one assigned
Labels
skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joker-eph @weliveindetail