Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAGCombine] Fix multi-use miscompile in load combine #81586

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[DAGCombine] Fix multi-use miscompile in load combine #81586

merged 1 commit into from
Feb 13, 2024

Commits on Feb 13, 2024

  1. [DAGCombine] Fix multi-use miscompile in load combine 

    The load combine replaces a number of original loads with one new
loads and also replaces the output chains of the original loads
with the output chain of the new load. This is incorrect if the
original load is retained (due to multi-use), as it may get
incorrectly reordered.

Fix this by using makeEquivalentMemoryOrdering() instead, which
will create a TokenFactor with both chains.
    @nikic
    nikic committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    98359f2 View commit details
    Browse the repository at this point in the history