Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] P2602R2 Poison Pills are Too Toxic #74534

Merged
merged 23 commits into from
Mar 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
aaccb9e
[libc++] P2602R2 Poison Pills are Too Toxic
JMazurkiewicz Dec 5, 2023
912bc3e
Make 🐍 formatter happy
JMazurkiewicz Dec 5, 2023
079d0e6
Merge branch 'main' into libcxx/ranges/poison-pills
JMazurkiewicz Jan 10, 2024
aabffdd
Formatting
JMazurkiewicz Jan 10, 2024
ccfae95
Formatting (again)
JMazurkiewicz Jan 10, 2024
5f0ad59
Merge branch 'main' into libcxx/ranges/poison-pills
JMazurkiewicz Feb 3, 2024
0b5275c
Code cleanup
JMazurkiewicz Feb 3, 2024
7562e18
Update docs
JMazurkiewicz Feb 5, 2024
caa3aca
Merge branch 'main' into libcxx/ranges/poison-pills
JMazurkiewicz Feb 5, 2024
9429bbf
Fix value of `__cpp_lib_ranges` FTM
JMazurkiewicz Feb 20, 2024
7680d14
Merge branch 'main' into libcxx/ranges/poison-pills
JMazurkiewicz Feb 20, 2024
d908384
Python formatting
JMazurkiewicz Feb 20, 2024
fec6936
Poke CI
JMazurkiewicz Feb 20, 2024
f0c2fe5
Poke CI (again)
JMazurkiewicz Feb 21, 2024
0df473e
Merge branch 'main' into libcxx/ranges/poison-pills
JMazurkiewicz Feb 22, 2024
510a91a
Separate ordinary unqualified lookup tests.
JMazurkiewicz Feb 26, 2024
a1dbe7d
Revert changes to `__cpp_lib_ranges`
JMazurkiewicz Feb 26, 2024
6201b0f
Whitespace cleanup
JMazurkiewicz Feb 26, 2024
58a8e52
Merge branch 'main' into libcxx/ranges/poison-pills
JMazurkiewicz Feb 26, 2024
84ca8f2
Merge branch 'main' into libcxx/ranges/poison-pills
JMazurkiewicz Feb 27, 2024
191568d
Merge `robust_against_ordinary_unqualified_lookup.compile.pass.cpp` t…
JMazurkiewicz Mar 7, 2024
2d54041
Merge branch 'main' into libcxx/ranges/poison-pills
JMazurkiewicz Mar 7, 2024
5328845
Merge branch 'main' into libcxx/ranges/poison-pills
JMazurkiewicz Mar 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting
  • Loading branch information
JMazurkiewicz committed Jan 10, 2024
commit aabffddfe5b976c681315ca0b72c2a0e6dcb06c1
2 changes: 1 addition & 1 deletion libcxx/test/std/ranges/range.access/begin.pass.cpp
Original file line number Diff line number Diff line change
@@ -196,7 +196,7 @@ struct BeginFunction {
};
static_assert( std::is_invocable_v<RangeBeginT, BeginFunction const&>);
static_assert(!std::is_invocable_v<RangeBeginT, BeginFunction &&>);
static_assert( std::is_invocable_v<RangeBeginT, BeginFunction &>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert(std::is_invocable_v<RangeBeginT, BeginFunction &>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert( std::is_invocable_v<RangeCBeginT, BeginFunction const&>);
static_assert( std::is_invocable_v<RangeCBeginT, BeginFunction &>);

2 changes: 1 addition & 1 deletion libcxx/test/std/ranges/range.access/end.pass.cpp
Original file line number Diff line number Diff line change
@@ -197,7 +197,7 @@ static_assert(!std::is_invocable_v<RangeEndT, EndFunction &&>);

static_assert( std::is_invocable_v<RangeEndT, EndFunction const&>);
static_assert(!std::is_invocable_v<RangeEndT, EndFunction &&>);
static_assert( std::is_invocable_v<RangeEndT, EndFunction &>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert(std::is_invocable_v<RangeEndT, EndFunction &>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert( std::is_invocable_v<RangeCEndT, EndFunction const&>);
static_assert( std::is_invocable_v<RangeCEndT, EndFunction &>);

3 changes: 2 additions & 1 deletion libcxx/test/std/ranges/range.access/rbegin.pass.cpp
Original file line number Diff line number Diff line change
@@ -191,7 +191,8 @@ struct RBeginFunction {
};
static_assert( std::is_invocable_v<RangeRBeginT, RBeginFunction const&>);
static_assert(!std::is_invocable_v<RangeRBeginT, RBeginFunction &&>);
static_assert( std::is_invocable_v<RangeRBeginT, RBeginFunction &>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert(
std::is_invocable_v<RangeRBeginT, RBeginFunction&>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert( std::is_invocable_v<RangeCRBeginT, RBeginFunction const&>);
static_assert( std::is_invocable_v<RangeCRBeginT, RBeginFunction &>);

2 changes: 1 addition & 1 deletion libcxx/test/std/ranges/range.access/rend.pass.cpp
Original file line number Diff line number Diff line change
@@ -200,7 +200,7 @@ static_assert(!std::is_invocable_v<RangeREndT, REndFunction &&>);

static_assert( std::is_invocable_v<RangeREndT, REndFunction const&>);
static_assert(!std::is_invocable_v<RangeREndT, REndFunction &&>);
static_assert( std::is_invocable_v<RangeREndT, REndFunction &>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert(std::is_invocable_v<RangeREndT, REndFunction &>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert( std::is_invocable_v<RangeCREndT, REndFunction const&>);
static_assert( std::is_invocable_v<RangeCREndT, REndFunction &>);

3 changes: 2 additions & 1 deletion libcxx/test/std/ranges/range.access/size.pass.cpp
Original file line number Diff line number Diff line change
@@ -223,7 +223,8 @@ inline constexpr bool std::ranges::disable_sized_range<const ImproperlyDisabledF

static_assert( std::is_invocable_v<RangeSizeT, ImproperlyDisabledMember&>);
static_assert( std::is_invocable_v<RangeSizeT, const ImproperlyDisabledMember&>);
static_assert( std::is_invocable_v<RangeSizeT, ImproperlyDisabledFunction&>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert(std::is_invocable_v<RangeSizeT,
ImproperlyDisabledFunction&>); // Ill-formed before P2602R2 Poison Pills are Too Toxic
static_assert( std::is_invocable_v<RangeSizeT, const ImproperlyDisabledFunction&>);

// No begin end.
Loading