Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP][Offload] Automatically map indirect function pointers #71462

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

jdoerfert
Copy link
Member

We already have all the information to automatically map function pointers that have been declared as indirect declare target by the user. This is just enabling and testing the functionality by looking through the one level of indirection.

We already have all the information to automatically map function
pointers that have been declared as `indirect` declare target by the
user. This is just enabling and testing the functionality by looking
through the one level of indirection.
@llvmbot llvmbot added the openmp:libomptarget OpenMP offload runtime label Nov 6, 2023
Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it seems that we were probably mapping the global that contained the address to the function rather than the function itself. LG.

@jdoerfert jdoerfert merged commit 2d739f1 into llvm:main Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants