Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for cmake failure #71404

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

j2kun
Copy link
Contributor

@j2kun j2kun commented Nov 6, 2023

I ran into this error as a newbie, was educated here. Updating the error message to be more descriptive about the problem and my options.

@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Nov 6, 2023
Copy link
Contributor

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always just drop the period from the extension lol.

Copy link
Collaborator

@joker-eph joker-eph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ftynse ftynse merged commit ebc3302 into llvm:main Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants