Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flang][OpenMP] Fix to support privatisation of alloc strings #71204

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[Flang][OpenMP] Fix to support privatisation of alloc strings #71204

merged 1 commit into from
Nov 7, 2023

Conversation

kiranchandramohan
Copy link
Contributor

No description provided.

@kiranchandramohan
Copy link
Contributor Author

@d-smirnov Could you have a look?

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir flang:openmp labels Nov 3, 2023
@d-smirnov
Copy link
Contributor

:shipit:

jeanPerier
jeanPerier approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@jeanPerier jeanPerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiranchandramohan kiranchandramohan merged commit 192bee0 into llvm:main Nov 7, 2023
4 of 6 checks passed
kiranchandramohan added a commit that referenced this pull request Nov 7, 2023
@kiranchandramohan
Revert "[Flang][OpenMP] Fix to support privatisation of alloc strings (…
ba116ff 
…#71204)"

This reverts commit 192bee0.
Reverting to fix the CI.  https://lab.llvm.org/buildbot/#/builders/21/builds/84995
kiranchandramohan added a commit that referenced this pull request Nov 7, 2023
@kiranchandramohan
Revert "Revert "[Flang][OpenMP] Fix to support privatisation of alloc…
d0ef94b 
… strings (#71204)""

This reverts commit ba116ff.

This relands #71204 with a fix
in the test.
This was referenced Nov 8, 2023
Closed
Closed
qihangkong pushed a commit to rvgpu/llvm that referenced this pull request Apr 18, 2024
@kiranchandramohan @zahiraam
Revert "Revert "[Flang][OpenMP] Fix to support privatisation of alloc…
010e2e0 
… strings (#71204)""

This reverts commit ba116ff.

This relands llvm/llvm-project#71204 with a fix
in the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanPerier jeanPerier jeanPerier approved these changes

Assignees
No one assigned
Labels
flang:fir-hlfir flang:openmp flang Flang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiranchandramohan @d-smirnov @jeanPerier @llvmbot