Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lit] Echo full RUN lines in case of external shells #66408

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[lit] Echo full RUN lines in case of external shells #66408

merged 1 commit into from
Sep 19, 2023

Commits on Sep 19, 2023

  1. [lit] Echo full RUN lines in case of external shells 

    Before <https://reviews.llvm.org/D154984> and
<https://reviews.llvm.org/D156954>, lit reported full RUN lines in a
`Script:` section.  Now, in the case of lit's internal shell, it's the
execution trace that includes them.  However, if lit is configured to
use an external shell (e.g., bash, windows `cmd`), they aren't
reported at all.

A fix was requested at the following:

* <https://reviews.llvm.org/D154984#4627605>
* <https://discourse.llvm.org/t/rfc-improving-lits-debug-output/72839/35?u=jdenny-ornl>

This patch does not address the case when the external shell is
windows `cmd`.  As discussed at
<llvm#65242>, it's not clear
whether that's a use case that people still care about, and it seems
to be generally broken anyway.
    @jdenny-ornl
    jdenny-ornl committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a76ca4c View commit details
    Browse the repository at this point in the history