Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AArch64] Split Ampere1Write_Arith into rr/ri and rs/rx InstRWs. #66384

Merged
merged 1 commit into from
Sep 14, 2023

Commits on Sep 14, 2023

  1. [AArch64] Split Ampere1Write_Arith into rr/ri and rs/rx InstRWs.

    The ampere1 scheduling model uses IsCheapLSL predicates for ADDXri and ADDWrr
    instructions, which only have 3 operands. In attempting to check that the third
    is a shift, the predicate can attempt to access an out of bounds operand,
    hitting an assert. This splits the rr/ri instructions (which can never have
    shifts) from the rs/rx instructions to ensure they both work correctly.
    Ampere1Write_1cyc_1AB was chosen for the rr/ir instructions to match the cheap
    case.
    
    This also sets CompleteModel = 0 for the ampere1 scheduling model, as at
    runtime under debug it will attempt to check that as well as all instructions
    having scheduling info, there is information for each output operand.
    
    DefIdx 1 exceeds machine model writes for
      renamable $w9, renamable $w8 = LDPWi renamable $x8, 0
    (Try with MCSchedModel.CompleteModel set to false)incomplete machine model
    davemgreen committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    820e8d5 View commit details
    Browse the repository at this point in the history