Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV] Install sifive_vector.h to riscv-resource-headers #66330

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

4vtomat
Copy link
Member

@4vtomat 4vtomat commented Sep 14, 2023

No description provided.

@4vtomat 4vtomat requested a review from a team September 14, 2023 06:01
@llvmbot llvmbot added clang Clang issues not falling into any other category backend:X86 clang:headers Headers provided by Clang, e.g. for intrinsics labels Sep 14, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 14, 2023

@llvm/pr-subscribers-backend-risc-v

@llvm/pr-subscribers-backend-x86

Changes None -- Full diff: https://github.com//pull/66330.diff

1 Files Affected:

  • (modified) clang/lib/Headers/CMakeLists.txt (+5)
diff --git a/clang/lib/Headers/CMakeLists.txt b/clang/lib/Headers/CMakeLists.txt
index 334bc13799409bb..1868357b2eb4b7a 100644
--- a/clang/lib/Headers/CMakeLists.txt
+++ b/clang/lib/Headers/CMakeLists.txt
@@ -623,6 +623,11 @@ install(
   EXCLUDE_FROM_ALL
   COMPONENT riscv-resource-headers)
 
+install(
+  FILES ${sifive_files}
+  DESTINATION ${header_install_dir}
+  COMPONENT riscv-resource-headers)
+
 install(
   FILES ${systemz_files}
   DESTINATION ${header_install_dir}

@eopXD
Copy link
Member

eopXD commented Sep 14, 2023

Maybe test coverage with -I %resource_dir?

@4vtomat
Copy link
Member Author

4vtomat commented Sep 14, 2023

Maybe test coverage with -I %resource_dir?

Which file should I place the test?

@eopXD
Copy link
Member

eopXD commented Sep 14, 2023

Maybe test coverage with -I %resource_dir?

Which file should I place the test?

clang/test/Headers/

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@4vtomat 4vtomat merged commit cb97761 into llvm:main Sep 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:RISC-V backend:X86 clang:headers Headers provided by Clang, e.g. for intrinsics clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants