-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clang][AST] fix lack comparison of declRefExpr in ASTStructuralEquivalence #66041
[clang][AST] fix lack comparison of declRefExpr in ASTStructuralEquivalence #66041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on that!
Can you explain why you are comparing declaration only with their name? that seems suspicious to me. Otherwise, I think the intent of the change is correct
1efbe57
to
18039e2
Compare
You should edit Otherwise LGTM |
18039e2
to
0ddd5db
Compare
0ddd5db
to
fd7138e
Compare
c602243
to
011c399
Compare
f74271d
to
a1635d8
Compare
LGTM! If no further comment I'll merge this in a day or two. |
a1635d8
to
7e4a54f
Compare
Fixes #66047
Before fix,the following testcase expected true. While I think only comparison of declName is not sufficient.Thanks for giving suggestions.