[mlir][bufferization] Move AllocationOpInterface implementations #65578
Conversation
The new Buffer Deallocation pass introduced in D158421 will not need the AllocationOpInterface anymore, thus it is better to move those default implementations to a place where they will still be used.
| }; | ||
| } // namespace | ||
|
|
||
| void bufferization::registerAllocationOpInterfaceExternalModels( |
There was a problem hiding this comment.
The name of the API really does not reflect that this is about the Memref dialect.
It's also not clear to me why lib/Dialect/Bufferization/Bufferize.cpp is the place to register an implementation of an interface for the Memref dialect?
There was a problem hiding this comment.
I wouldn't necessarily say that this is just an interface for the memref dialect. I think it's more an interface to customize various bufferization passes (e.g., buffer hoisting). In the extreme case to make them work on other dialects than just memref.
In the long-term I think it would be better to split this interface into one per bufferization pass (currently that would be one for hoisting and one for buffer promotion, the parts used for deallocation would be removed) and name them accordingly. The implementations would live in the dialect directory of the ops for which it is implemented.
In the short term I can offer to move the interface implementations to BufferOptimization.cpp where it is actually used (and not just registered). Ideally, we would move the implementation for alloc, alloca, and realloc in MemRef/Transforms/AllocationOpInterfaceImpl.cpp and the implementation of clone in Bufferization/Transforms/AllocationOpInterface.cpp, however, this is not possible because it would introduce a dependency cycle (bufferization <-> memref) unless the interface declaration is moved out of the bufferization dialect build target. But where should it go then? A new BufferizationInterfaces target?
What do you think?
There was a problem hiding this comment.
I wouldn't necessarily say that this is just an interface for the memref dialect. I think it's more an interface to customize various bufferization passes (e.g., buffer hoisting). In the extreme case to make them work on other dialects than just memref.
I agree that the interface isn't specific to Memref, but this is one particular implementation of the interface which is specific to the Memref dialect.
Ideally, we would move the implementation for alloc, alloca, and realloc in MemRef/Transforms/AllocationOpInterfaceImpl.cpp
Right this is what I was pointing out actually :)
however, this is not possible because it would introduce a dependency cycle (bufferization <-> memref)
Actually if it is a library of its own in the Memref dialect, there wouldn't be any cycle.
More importantly, you don't need an actually dependency to implement an interface: that is implementing AllocationOpInterfaceImpl.cpp does not need to depend on Bufferization, even if the interface is declared by Bufferization.
(see for example how mlir/IR implements a Bytecode interface but the ByteCode library depends on IR)
…llvm#65578) The new Buffer Deallocation pass introduced in D158421 will not need the AllocationOpInterface anymore, thus it is better to move those default implementations to a place where they will still be used.
…ocationOpInterface to memref dialect directory (llvm#66637) Follow-up on llvm#65578
The new Buffer Deallocation pass introduced in D158421 will not need the AllocationOpInterface anymore, thus it is better to move those default implementations to a place where they will still be used.