[mlir] regenerate linalg named ops yaml #65475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
mlir:core
nicolasvasilache
approved these changes
Sep 6, 2023
I suppose the ODS generator based on this doesn't do any type checking on YAML (bang expressions are types).
Trying to add new op with OpDSL made me call the generator script, a big diff showed up as a result. |
The Linalg named ops specification went out of sync with the OpDSL description, presumably due to direct manual modifications of the yaml file. Additionally, the unsigned division has been generating the signed scalar instruction, which is now fixed.
ftynse
force-pushed
the
fix-named-ops
branch
from
a86a9ba
to
bb082c2
Compare
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linalg named ops specification went out of sync with the OpDSL description, presumably due to direct manual modifications of the yaml file.
Additionally, the unsigned division has been generating the signed scalar instruction, which is now fixed.