[libc++] Implement LWG3545: std::pointer_traits should be SFINAE-friendly. #65177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricWF
requested changes
Sep 1, 2023
libcxx/test/std/utilities/memory/pointer.conversion/to_address.verify.cpp
Outdated
Show resolved
Hide resolved
libcxx/test/std/utilities/memory/pointer.conversion/to_address_without_pointer_traits.pass.cpp
Show resolved
Hide resolved
philnik777
added
the
libc++
zetafunction
force-pushed
the
pointer_traits_sfinae
branch
from
b6b1d69 to
0778e3e
Compare
…ndly. See https://wg21.link/LWG3545 for background and details. Differential Revision: https://reviews.llvm.org/D158922
zetafunction
force-pushed
the
pointer_traits_sfinae
branch
from
0778e3e to
a47d0c6
Compare
ldionne
requested changes
Sep 12, 2023
| @@ -0,0 +1,176 @@ | |||
| //===----------------------------------------------------------------------===// | |||
There was a problem hiding this comment.
These tests look really nice, but we should merge them with the ones in libcxx/test/std/utilities/memory/pointer.traits/* (for example libcxx/test/std/utilities/memory/pointer.traits/difference_type.pass.cpp).
I think it might make sense to consolidate them in a single libcxx/test/std/utilities/memory/pointer.traits/types.pass.cpp.
libcxx/test/std/utilities/memory/pointer.conversion/to_address.verify.cpp
Outdated
Show resolved
Hide resolved
libcxx/test/std/utilities/memory/pointer.conversion/to_address_without_pointer_traits.pass.cpp
Show resolved
Hide resolved
ldionne
requested changes
Sep 12, 2023
libcxx/test/std/utilities/memory/pointer.conversion/to_address.verify.cpp
Outdated
Show resolved
Hide resolved
The standard doesn't define pointer_traits until C++11, but there are some existing tests that seem to test in C++03 mode... so try to preserve that behavior in the updated tests.
ldionne
requested changes
Sep 13, 2023
| ASSERT_SAME_TYPE(typename std::pointer_traits<Ptr>::rebind<long>::other, long*); | ||
| #endif | ||
|
|
||
| assert(HasPointerTo<Ptr>::value); |
There was a problem hiding this comment.
The test for pointer_to shouldn't be in types.compile.pass.cpp since it's not a compile-time only test.
There was a problem hiding this comment.
If I change it to using static_assert (which I did), is it OK to leave it here?
|
@zetafunction I added some suggestions to try and capture what I want here, feel free to reach out on Discord if you want, sometimes it's easier to transmit the exact intent when chatting live. |
ldionne
approved these changes
Sep 18, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…ndly. (llvm#65177) See https://wg21.link/LWG3545 for background and details. Differential Revision: https://reviews.llvm.org/D158922
ldionne
added a commit
to ldionne/llvm-project
that referenced
this pull request
Sep 27, 2023
Even though the underlying issue was fixed in llvm#65177 when we made std::pointer_traits SFINAE-friendly, it is worth adding a regression test since it's so easy to do.
ldionne
added a commit
that referenced
this pull request
Sep 28, 2023
legrosbuffle
pushed a commit
to legrosbuffle/llvm-project
that referenced
this pull request
Sep 29, 2023
Even though the underlying issue was fixed in llvm#65177 when we made std::pointer_traits SFINAE-friendly, it is worth adding a regression test since it's so easy to do.
zahiraam
pushed a commit
to tahonermann/llvm-project
that referenced
this pull request
Oct 24, 2023
…ndly. (llvm#65177) See https://wg21.link/LWG3545 for background and details. Differential Revision: https://reviews.llvm.org/D158922
zahiraam
pushed a commit
to tahonermann/llvm-project
that referenced
this pull request
Oct 24, 2023
…ndly. (llvm#65177) See https://wg21.link/LWG3545 for background and details. Differential Revision: https://reviews.llvm.org/D158922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://wg21.link/LWG3545 for background and details.
Differential Revision: https://reviews.llvm.org/D158922
One question I have is if this needs to be limited to C++23 and above. For full disclosure, it would be more useful to me if it were not, and it seems like it'd be OK to allow this to leak through to previous C++ versions, since those programs wouldn't have compiled anyway.