Skip to content

[analyzer] Retain address space information in getElementRegion #151370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025
Merged

[analyzer] Retain address space information in getElementRegion #151370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
690e311
[analyzer] Retain address space information in getElementRegion
NagyDonat Jul 30, 2025
2ceb18b
Apply suggestions from code review
NagyDonat Jul 31, 2025
970014f
Revert simplification because LangAS is not convertible to bool
NagyDonat Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions clang/lib/StaticAnalyzer/Core/MemRegion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,6 +1219,16 @@ MemRegionManager::getElementRegion(QualType elementType, NonLoc Idx,
const ASTContext &Ctx) {
QualType T = Ctx.getCanonicalType(elementType).getUnqualifiedType();

// The address space must be preserved because some target-specific address
// spaces influence the size of the pointer value which is represented by the
// element region.
LangAS AS = elementType.getAddressSpace();
if (AS != LangAS::Default) {
Qualifiers Quals;
Quals.setAddressSpace(AS);
T = Ctx.getQualifiedType(T, Quals);
}

llvm::FoldingSetNodeID ID;
ElementRegion::ProfileRegion(ID, T, Idx, superRegion);

Expand Down
11 changes: 11 additions & 0 deletions clang/test/Analysis/element-region-address-space.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// RUN: %clang_analyze_cc1 -triple amdgcn-unknown-unknown \
// RUN: -analyzer-checker=core -verify %s

// expected-no-diagnostics
//
// By default, pointers are 64-bits.
#define ADDRESS_SPACE_32BITS __attribute__((address_space(3)))

int test(ADDRESS_SPACE_32BITS int *p, ADDRESS_SPACE_32BITS void *q) {
return p == q; // no-crash
}