[clang][test] Specify value of -fopenmp=libomp for test.
#150301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`libomp` is the default value when unconfigured in cmake, but llvm can be configured to have libgomp be the default instead. Explicitly specify this value so the test does not fail when it assumes libomp is always the default.
llvmbot
added
clang
|
@llvm/pr-subscribers-clang-driver Author: Jordan Rupprecht (rupprecht) Changes
Full diff: https://github.com/llvm/llvm-project/pull/150301.diff 1 Files Affected:
diff --git a/clang/test/Driver/offload-target.c b/clang/test/Driver/offload-target.c
index 123ecd3eb830e..23a2cf26eb192 100644
--- a/clang/test/Driver/offload-target.c
+++ b/clang/test/Driver/offload-target.c
@@ -10,7 +10,7 @@
// RUN: | FileCheck %s -check-prefix=CUDA
// CUDA: "nvptx64-nvidia-cuda" - "clang", inputs: ["[[INPUT:.+]]"], output: "[[NV_OBJ:.+]]"
-// RUN: %clang -### --offload-targets=amdgcn-amd-amdhsa,nvptx64-nvidia-cuda -fopenmp \
+// RUN: %clang -### --offload-targets=amdgcn-amd-amdhsa,nvptx64-nvidia-cuda -fopenmp=libomp \
// RUN: -Xarch_amdgcn --offload-arch=gfx90a -Xarch_nvptx64 --offload-arch=sm_89 \
// RUN: -nogpulib -nogpuinc %s -ccc-print-bindings 2>&1 \
// RUN: | FileCheck %s -check-prefix=OPENMP
|
|
@llvm/pr-subscribers-clang Author: Jordan Rupprecht (rupprecht) Changes
Full diff: https://github.com/llvm/llvm-project/pull/150301.diff 1 Files Affected:
diff --git a/clang/test/Driver/offload-target.c b/clang/test/Driver/offload-target.c
index 123ecd3eb830e..23a2cf26eb192 100644
--- a/clang/test/Driver/offload-target.c
+++ b/clang/test/Driver/offload-target.c
@@ -10,7 +10,7 @@
// RUN: | FileCheck %s -check-prefix=CUDA
// CUDA: "nvptx64-nvidia-cuda" - "clang", inputs: ["[[INPUT:.+]]"], output: "[[NV_OBJ:.+]]"
-// RUN: %clang -### --offload-targets=amdgcn-amd-amdhsa,nvptx64-nvidia-cuda -fopenmp \
+// RUN: %clang -### --offload-targets=amdgcn-amd-amdhsa,nvptx64-nvidia-cuda -fopenmp=libomp \
// RUN: -Xarch_amdgcn --offload-arch=gfx90a -Xarch_nvptx64 --offload-arch=sm_89 \
// RUN: -nogpulib -nogpuinc %s -ccc-print-bindings 2>&1 \
// RUN: | FileCheck %s -check-prefix=OPENMP
|
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
`libomp` is the default value when unconfigured in cmake, but llvm can be configured to have `libgomp` be the default instead. Explicitly specify this value so the test does not fail when it assumes libomp is always the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libompis the default value when unconfigured in cmake, but llvm can be configured to havelibgompbe the default instead. Explicitly specify this value so the test does not fail when it assumes libomp is always the default.This is needed for the test changes in #125556