[Support][BLAKE3] Prefix blake3_xof_many_avx512 #148607
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This symbol was introduced in llvm#147948, but not prefixed, resulting in conflicts if libblake3 and LLVM are both linked statically into the same binary.
|
@llvm/pr-subscribers-llvm-support Author: Nikita Popov (nikic) ChangesThis symbol was introduced in #147948, but not prefixed, resulting in conflicts if libblake3 and LLVM are both linked statically into the same binary. Full diff: https://github.com/llvm/llvm-project/pull/148607.diff 1 Files Affected:
diff --git a/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h b/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h
index 3cee3691e4cf7..d5be360815add 100644
--- a/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h
+++ b/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h
@@ -34,6 +34,8 @@
#define _blake3_compress_in_place_avx512 _llvm_blake3_compress_in_place_avx512
#define blake3_compress_xof_avx512 llvm_blake3_compress_xof_avx512
#define _blake3_compress_xof_avx512 _llvm_blake3_compress_xof_avx512
+#define blake3_xof_many_avx512 llvm_blake3_xof_many_avx512
+#define _blake3_xof_many_avx512 _llvm_blake3_xof_many_avx512
#define blake3_hash_many_avx512 llvm_blake3_hash_many_avx512
#define _blake3_hash_many_avx512 _llvm_blake3_hash_many_avx512
#define blake3_hash_many_neon llvm_blake3_hash_many_neon
|
akyrtzi
approved these changes
Jul 14, 2025
|
Thank you for the catch and fix! |
|
(merging since this should fix our CI) |
rust-bors bot
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 15, 2025
Update to LLVM 21 Depends on: * [x] llvm/llvm-project#147781 * [x] llvm/llvm-project#147935 * [x] llvm/llvm-project#139443 * [x] llvm/llvm-project#148207 * [x] llvm/llvm-project#148607 r? `@ghost`
rupprecht
added a commit
to rupprecht/llvm-project
that referenced
this pull request
Jul 16, 2025
Added by llvm#147948, blake3_xof_many and blake3_compress_subtree_wide cause conflicts when linking llvm and blake3 statically into the same binary. Similar to llvm#148607.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This symbol was introduced in #147948, but not prefixed, resulting in conflicts if libblake3 and LLVM are both linked statically into the same binary.