-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backtrace support for flang #118179
Merged
Backtrace support for flang #118179
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2d5d310
[flang]Add new intrinsic function backtrace and complete the TODO of …
dty2 6b57193
commit some suggestions
dty2 0862afd
Merge branch 'main' into dty2
dty2 d28136f
[flang]Import the header file config.h in flang/runtime/stop.cpp and …
dty2 bf60ffe
Merge branch 'dty2' of github.com:dty2/llvm-project into dty2
dty2 594c2b3
Merge branch 'main' into dty2
dty2 ca2ceb5
[flang]Handle the case when a backtrace is not available
dty2 156e434
Merge branch 'dty2' of github.com:dty2/llvm-project into dty2
dty2 6c22384
Merge branch 'main' into dty2
dty2 c2e4cca
[flang]update format
dty2 0270969
Merge branch 'dty2' of github.com:dty2/llvm-project into dty2
dty2 d3df426
Merge branch 'main' into dty2
dty2 96a861c
Merge branch 'main' into dty2
dty2 30e5858
[flang]Fix missing file issue
dty2 d7af048
[flang]format
dty2 f2fdf26
[flang]Solved the build problem in window environment
dty2 6e6c1a5
[flang]format
dty2 1e59e61
use FORTRAN_PROCEDURE_NAME
dty2 441eede
update Intrinstic doc
dty2 624a42a
change ABORT
dty2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make that one also conditional on
#ifdef HAVE_BACKTRACE
I do not think ABORT should crash with "Handle the case when a backtrace is not available\n" on platforms that have no backtrace.It could lead people to believe that the abort is related to BACKTRACE while it is not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, thanks for pointing this out.