Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDAG] Don't allow implicit trunc in getConstant() #117558

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[SDAG] Don't allow implicit trunc in getConstant() #117558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1195b05
[SDAG] Don't allow implicit trunc in getConstant()
nikic Nov 15, 2024
3f6bf27
use getScalarSizeInBits
nikic Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1637,14 +1637,7 @@ SDValue SelectionDAG::getBoolConstant(bool V, const SDLoc &DL, EVT VT,

SDValue SelectionDAG::getConstant(uint64_t Val, const SDLoc &DL, EVT VT,
bool isT, bool isO) {
EVT EltVT = VT.getScalarType();
assert((EltVT.getSizeInBits() >= 64 ||
(uint64_t)((int64_t)Val >> EltVT.getSizeInBits()) + 1 < 2) &&
"getConstant with a uint64_t value that doesn't fit in the type!");
// TODO: Avoid implicit trunc?
// See https://github.com/llvm/llvm-project/issues/112510.
return getConstant(APInt(EltVT.getSizeInBits(), Val, /*isSigned=*/false,
/*implicitTrunc=*/true),
return getConstant(APInt(VT.getScalarSizeInBits(), Val, /*isSigned=*/false),
DL, VT, isT, isO);
}

Expand Down
Loading