[SandboxIR] Add utility function to find the base Value for Mem instructions #112030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmsri
approved these changes
Oct 11, 2024
vporpo
reviewed
Oct 11, 2024
| @@ -49,6 +49,16 @@ class Utils { | |||
| return const_cast<Instruction *>(I); | |||
| } | |||
|
|
|||
| /// \Returns the base Value for load or store instruction \p LSI. | |||
| template <typename LoadOrStoreT> | |||
| static Value *getMemInstructionBase(const LoadOrStoreT *LSI) { | |||
There was a problem hiding this comment.
Why not use LLVM's name getUnderlyingObject() ? getMemInstructionBase() is a better name, but since we are just wrapping LLVM's getUnderlyingObject() we should probably stick to the same name.
There was a problem hiding this comment.
Because this does more than just wrap getUnderlyingObject. It also finds the pointer operand.
| static_assert(std::is_same_v<LoadOrStoreT, LoadInst> || | ||
| std::is_same_v<LoadOrStoreT, StoreInst>, | ||
| "Expected sandboxir::Load or sandboxir::Store!"); | ||
| return LSI->Ctx.getOrCreateValue( |
There was a problem hiding this comment.
Do we need getOrCreateValue() ? I assume that sandbox IR would have been generated for the whole function. That would remove the need for friend class Utils in Context.
auto *V = LSI->Ctx.getValue( getUnderlyingObject(LSI->getPointerOperand()->Val));
assert(V != nullptr && "Missing Sandbox IR value!");
return V;
There was a problem hiding this comment.
getUnderlyingObject returns an llvm::Value, getOrCreateValue converts that to a sandboxir::Value.
There was a problem hiding this comment.
Yes, but there is also a public sandboxir::Context::getValue(llvm::Value *) that converts LLVM IR to Sandbox IR
| EXPECT_EQ(sandboxir::Utils::getMemInstructionBase(St2), | ||
| sandboxir::Utils::getMemInstructionBase(St3)); | ||
| EXPECT_NE(sandboxir::Utils::getMemInstructionBase(St0), | ||
| sandboxir::Utils::getMemInstructionBase(St3)); |
There was a problem hiding this comment.
These checks are OK, but we are not actually checking what the returned value actually is.
Some checks like this would also help:
EXPECT_EQ(sandboxir::Utils::getMemInsructionBase(St0), Ctx.getValue(LLVMSt0));
There was a problem hiding this comment.
will add
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/8098 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/6050 Here is the relevant piece of the build log for the reference |
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
bricknerb
pushed a commit
to bricknerb/llvm-project
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.